Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3357#discussion_r102498672
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/TableWithSQLITCase.scala
---
@@ -113,4 +114,26 @@ class TableWithSQLITCase(
val results = result.toDataSet[Row].collect()
TestBaseUtils.compareResultAsText(results.asJava, expected)
}
+
+ @Test
+ def testUDTFWithPojoType(): Unit = {
--- End diff --
We should keep ITCases to a very minimum, because they are very expensive.
Espacially, we should not add 4 ITCases for a one line change. I think it is
sufficient if we just extend an existing test in
`DataSetUserDefinedFunctionITCase` and `DataStreamUserDefinedFunctionITCase`.
You could e.g. rename `testLongAndTemporalTypes` to `testDifferentTypes` and
add a POJO there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
