Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r102896783
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -176,7 +177,7 @@ public FlinkKafkaConsumer08(List<String> topics,
DeserializationSchema<T> deseri
* @param props
* The properties that are used to configure both the fetcher
and the offset handler.
*/
- public FlinkKafkaConsumer08(List<String> topics,
KeyedDeserializationSchema<T> deserializer, Properties props) {
+ public FlinkKafkaConsumer08(List<String> topics,
RichKeyedDeserializationSchema<T> deserializer, Properties props) {
--- End diff --
This will break user-code. We'll need proper usage migration here.
We have a separate JIRA that aims at deprecating the current Kafka Consumer
constructors: https://issues.apache.org/jira/browse/FLINK-5704. The migration
to use the new flat-map deserialzer can be included there.
Perhaps for this PR, we should just use your
`RichKeyedDeserializationSchemaWrapper` as "behaviour bridges" for the original
deserialization schema to the new one, and don't change the original
constructor / include new constructors yet, so that we don't overlap and
complicate things for FLINK-5704.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
