Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r102925177
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -563,7 +590,14 @@ private void emitWindowContents(W window, ACC
contents) throws Exception {
* of the given window.
*/
protected boolean isLate(W window) {
- return (windowAssigner.isEventTime() && (cleanupTime(window) <=
internalTimerService.currentWatermark()));
+ if (windowAssigner.isEventTime()) {
+ if (windowAssigner instanceof
GlobalEventTimeRowWindowAssigner) {
+ return
windowAssignerContext.getCurrentElementTime() <
windowAssignerContext.getCurrentMaxTime();
--- End diff --
I think this logic does not work very well if the data arrives is out of
order. How do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
