[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882727#comment-15882727
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r102759091
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -732,7 +765,21 @@ public RegistrationResponse apply(TaskExecutorGateway
taskExecutorGateway, Throw
slotPoolGateway.registerTaskManager(taskManagerId);
registeredTaskManagers.put(taskManagerId, Tuple2.of(taskManagerLocation,
taskExecutorGateway));
- return new
JMTMRegistrationSuccess(taskManagerId, libraryCacheManager.getBlobServerPort());
+
+ // monitor the task manager as
heartbeat target
+
heartbeatManager.monitorTarget(taskManagerId, new HeartbeatTarget<Void>() {
+ @Override
+ public void
sendHeartbeat(ResourceID resourceID, Void payload) {
+ // the task manager
will not request heartbeat, so this method will never be called currently
+ }
+
+ @Override
+ public void
requestHeartbeat(ResourceID resourceID, Void payload) {
+
taskExecutorGateway.heartbeatFromJobManager(resourceID);
+ }
+ });
+
+ return new
JMTMRegistrationSuccess(JobMaster.this.resourceID,
libraryCacheManager.getBlobServerPort());
--- End diff --
`JobMaster.this.` not needed
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhijiang
> Assignee: zhijiang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
