Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3378#discussion_r103196367
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -330,8 +315,49 @@ public void cancel() {
public void open(Configuration configuration) {
--- End diff --
I wonder if it makes sense to move the method above the run() method.
Then its more logical going through the source code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
