[ 
https://issues.apache.org/jira/browse/FLINK-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885738#comment-15885738
 ] 

ASF GitHub Bot commented on FLINK-5815:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3388#discussion_r103196163
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -742,6 +755,24 @@ public FileVisitResult 
preVisitDirectory(java.nio.file.Path dir, BasicFileAttrib
                        }
                }
     
    +           for (URI originURI : archives) {
    +                   Path remoteParent = 
Utils.getRemoteResourceRoot(appId.toString(), new Path(originURI.getPath()), 
fs.getHomeDirectory());
    +                   String fragment = originURI.getFragment();
    +                   Path target = new Path(
    +                           FileUtils.localizeRemoteFiles(new 
org.apache.flink.core.fs.Path(remoteParent.toUri()), originURI).toUri());
    +                   URI targetURI = target.toUri();
    +                   if (targetURI.getFragment() == null && fragment != 
null) {
    +                           targetURI = new URI(target.toUri().toString() + 
"#" + fragment);
    --- End diff --
    
    Haven't we already extracted the target URI in `targetURI`?


> Add resource files configuration for Yarn Mode
> ----------------------------------------------
>
>                 Key: FLINK-5815
>                 URL: https://issues.apache.org/jira/browse/FLINK-5815
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client, YARN
>    Affects Versions: 1.3.0
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> Currently in flink, when we want to setup a resource file to distributed 
> cache, we need to make the file accessible remotely by a url, which is often 
> difficult to maintain a service like that. What's more, when we want do add 
> some extra jar files to job classpath, we need to copy the jar files to blob 
> server when submitting the jobgraph. In yarn, especially in flip-6, the blob 
> server is not running yet when we try to start a flink job. 
> Yarn has a efficient distributed cache implementation for application running 
> on it, what's more we can be easily share the files stored in hdfs in 
> different application by distributed cache without extra IO operations. 
> I suggest to introduce -yfiles, -ylibjars -yarchives options to FlinkYarnCLI 
> to enable yarn user setup their job resource files by yarn distributed cache. 
> The options is compatible with what is used in mapreduce, which make it easy 
> to use for yarn user who generally has experience on using mapreduce.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to