Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3388#discussion_r103181903
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/FileUtils.java ---
    @@ -258,7 +261,82 @@ public static boolean deletePathIfEmpty(FileSystem 
fileSystem, Path path) throws
                        return false;
                }
        }
    -   
    +
    +   /**
    +    * Check whether the two given filesystem is the same or not
    +    *
    +    * @param srcFs
    +    * @param destFs
    +    * @return
    +    */
    +   public static boolean compareFs(FileSystem srcFs, FileSystem destFs) {
    --- End diff --
    
    Don't we compare two URIs instead of two filesystems here? The only purpose 
we pass `srcFs` and `destFs` to this method is to obtain their URIs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to