[
https://issues.apache.org/jira/browse/FLINK-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885779#comment-15885779
]
ASF GitHub Bot commented on FLINK-5907:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3417#discussion_r103197216
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -400,7 +400,7 @@ public void readMixedQuotedStringFields() {
@Test
public void readStringFieldsWithTrailingDelimiters() {
try {
- final String fileContent =
"abc|-def|-ghijk\nabc|-|-hhg\n|-|-|-\n";
+ final String fileContent =
"abc|-def|-ghijk\nabc|-|-hhg\n|-|-|-\n|-|-\nabc|-def\n";
--- End diff --
This method tests whether an additional field delimiter at the end is
accepted.
Can you move the checks for correctly identifying empty last fields into a
separate `testTailingEmptyFields` method?
> RowCsvInputFormat bug on parsing tsv
> ------------------------------------
>
> Key: FLINK-5907
> URL: https://issues.apache.org/jira/browse/FLINK-5907
> Project: Flink
> Issue Type: Bug
> Components: Java API
> Affects Versions: 1.2.0
> Reporter: Flavio Pompermaier
> Assignee: Kurt Young
> Labels: csv, parsing
> Attachments: test.tsv
>
>
> The following snippet reproduce the problem (using the attached file as
> input):
> {code:language=java}
> char fieldDelim = '\t';
> TypeInformation<?>[] fieldTypes = new TypeInformation<?>[51];
> for (int i = 0; i < fieldTypes.length; i++) {
> fieldTypes[i] = BasicTypeInfo.STRING_TYPE_INFO;
> }
> int[] fieldMask = new int[fieldTypes.length];
> for (int i = 0; i < fieldMask.length; i++) {
> fieldMask[i] = i;
> }
> RowCsvInputFormat csvIF = new RowCsvInputFormat(new Path(testCsv),
> fieldTypes, "\n", fieldDelim +"",
> fieldMask, true);
> csvIF.setNestedFileEnumeration(true);
> DataSet<Row> csv = env.createInput(csvIF);
> csv.print()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
