Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3303
Hi @StephanEwen , thanks for detail reviews of this PR and I learnt a lot
from your comments.
I considered all your suggestions above and submitted the modifications,
including:
1. Comment out to remove **setters** which would be exposed to users and
just keep the **getters**.
2. Use **preferredResource** instead of **maxResource** in order not to
confuse users.
3. Use **@Nullable** annotation for some variables.
4. Distinguish between **checkNotNull** and **checkArgument**.
5. Modifications in scala-like way, consider the
**BatchScalaAPICompletenessTest** and **StreamingScalaAPICompletenessTest**,
some methods should be the same between java and scala.
BTW, after this PR merge, I would submit the blocked codes related with
**JobGraph** generation and runtime stack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
