[ 
https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886691#comment-15886691
 ] 

ASF GitHub Bot commented on FLINK-5133:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3303
  
    I have merged this to my local repository.
    There were some issues left, partly in the commented out code.
    
    In particular `checkNotNull(variable !=null) does not work, because 
`variable !=null` evaluates to `Boolean(true)` or Boolean(false)` and then the 
check is that the Boolean is not null (which is always true).
    
    I fixed that and also renamed the variables to use "resources" consistently 
as plural, and harmonized the Java getter style.
    Will merge to Flink master tomorrow if the tests pass...


> Support to set resource for operator in DataStream and DataSet
> --------------------------------------------------------------
>
>                 Key: FLINK-5133
>                 URL: https://issues.apache.org/jira/browse/FLINK-5133
>             Project: Flink
>          Issue Type: Sub-task
>          Components: DataSet API, DataStream API
>            Reporter: zhijiang
>            Assignee: zhijiang
>
> This is part of the fine-grained resource configuration.
> For *DataStream*, the *setResource* API will be setted onto 
> *SingleOutputStreamOperator* similar with other existing properties like 
> parallelism, name, etc.
> For *DataSet*, the *setResource* API will be setted onto *Operator* in the 
> similar way.
> There are two parameters described with minimum *ResourceSpec* and maximum 
> *ResourceSpec* separately in the API for considering resource resize in 
> future improvements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to