[
https://issues.apache.org/jira/browse/FLINK-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887370#comment-15887370
]
ASF GitHub Bot commented on FLINK-5921:
---------------------------------------
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3425#discussion_r103384285
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
@@ -327,6 +329,15 @@ object FunctionGenerator {
)
)
+ // generate a constant for time indicator functions.
+ // this is a temporary solution and will be removed when FLINK-5884
is implemented.
+ case ProcTimeExtractor | EventTimeExtractor =>
+ Some(new CallGenerator {
+ override def generate(codeGenerator: CodeGenerator, operands:
Seq[GeneratedExpression]) = {
+ GeneratedExpression("0L", "false", "", LONG_TYPE_INFO)
--- End diff --
Can we change `LONG_TYPE_INFO` to `SqlTimeTypeInfo.TIMESTAMP`?
> Adapt time mode indicator functions return custom data types
> ------------------------------------------------------------
>
> Key: FLINK-5921
> URL: https://issues.apache.org/jira/browse/FLINK-5921
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> The functions that indicate event time ({{rowtime()}}) and processing time
> ({{proctime()}}) are defined to return {{TIMESTAMP}}.
> These functions should be updated to return custom types in order to ease the
> identification of the time semantics during optimization.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
