[
https://issues.apache.org/jira/browse/FLINK-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888443#comment-15888443
]
ASF GitHub Bot commented on FLINK-5852:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3365#discussion_r103502713
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java
---
@@ -54,6 +54,19 @@ public ArchivedExecutionConfig(ExecutionConfig ec) {
}
}
+ public ArchivedExecutionConfig(
--- End diff --
I wasn't mixing things up. For example, in ```Execution#archive()``` we
create an ```ArchivedExecution``` through the use of the
```ArchivedExecution(Execution)``` constructor. This pattern is identical for
all Archived* classes except the EG (because we need some internal components
and dont want to overload the class even more).
Changing the constructor implies changing the ExecutionConfig, which imo is
out of scope of this PR. Also, to be consistent, we would also have to touch
other ```Archivable``` classes as well.
> Move JSON generation code into static methods
> ---------------------------------------------
>
> Key: FLINK-5852
> URL: https://issues.apache.org/jira/browse/FLINK-5852
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.3.0
>
>
> In order to implement the HistoryServer we need a way to generate the JSON
> responses independent of the REST API. As such i suggest to move the main
> parts of the generation code for job-specific handlers into static methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
