[
https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888735#comment-15888735
]
ASF GitHub Bot commented on FLINK-5253:
---------------------------------------
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/3356
@StephanEwen I agree that the YARN AM/TM has no need for dynamic properties
since the entire config file is generated per container. But there's a case
to be made that dynamic properties on the CLI makes sense for some cluster
managers. Imagine a Kubernetes deployment using a docker image with Flink
pre-installed & (mostly) pre-configured. It would make sense to pass the JM
RPC port (which Kubernetes generates on-the-fly) as a dynamic property, e.g:
```
bin/flink-jobmanager.sh -Djobmanager.rpc.port=$PORT0
```
The mesos jobmanager and taskmanager use this approach for similar reasons.
> Remove special treatment of "dynamic properties"
> ------------------------------------------------
>
> Key: FLINK-5253
> URL: https://issues.apache.org/jira/browse/FLINK-5253
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Environment: {{flip-6}} feature branch
> Reporter: Stephan Ewen
> Labels: flip-6
>
> The YARN client accepts configuration keys as command line parameters.
> Currently these are send to the AppMaster and TaskManager as "dynamic
> properties", encoded in a special way via environment variables.
> The mechanism is quite fragile. We should simplify it:
> - The YARN client takes the local {{flink-conf.yaml}} as the base.
> - It overwrite config entries with command line properties when preparing
> the configuration to be shipped to YARN container processes (JM / TM)
> - No additional handling neccessary
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
