[
https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889758#comment-15889758
]
ASF GitHub Bot commented on FLINK-5881:
---------------------------------------
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103632353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,26 @@ object UserDefinedFunctionUtils {
s"one method named 'eval' which is public, not abstract and " +
s"(in case of table functions) not static.")
} else {
+ methods.foreach(method => {
+ val signatures = method.getParameterTypes
+ if (signatures.nonEmpty &&
+ signatures.last.getName.equals("scala.collection.Seq") &&
+ // If users specified an @varargs, Scala will generate two
methods indeed.
+ // If there does not exists corresponding varargs method of
the Seq method,
+ // we will throw an ValidationException.
+ (!methods.exists(m => {
+ val sigs = m.getParameterTypes
+ m.isVarArgs &&
+ sigs.length == signatures.length &&
+ sigs.zipWithIndex.forall { case (sig, i) =>
+ i == sigs.length - 1 || sig.equals(signatures(i))
+ }
+ }))) {
+ throw new ValidationException("The 'eval' method do not support
Scala type of " +
--- End diff --
I've updated the patch and refactored the logic.
> ScalarFunction(UDF) should support variable types and variable arguments
> -------------------------------------------------------------------------
>
> Key: FLINK-5881
> URL: https://issues.apache.org/jira/browse/FLINK-5881
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhuoluo Yang
> Assignee: Zhuoluo Yang
>
> As a sub-task of FLINK-5826. We would like to support the ScalarFunction
> first and make the review a little bit easier.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
