[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891454#comment-15891454
]
ASF GitHub Bot commented on FLINK-5768:
---------------------------------------
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103835523
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -54,31 +58,31 @@ object AggregateUtil {
* organized by the following format:
*
* {{{
- * avg(x) aggOffsetInRow = 2 count(z)
aggOffsetInRow = 5
- * | |
- * v v
- * +---------+---------+--------+--------+--------+--------+
- * |groupKey1|groupKey2| sum1 | count1 | sum2 | count2 |
- * +---------+---------+--------+--------+--------+--------+
+ * avg(x) count(z)
+ * | |
+ * v v
+ *
+---------+---------+-----------------+------------------+------------------+
+ * |groupKey1|groupKey2| AvgAccumulator | SumAccumulator |
CountAccumulator |
+ *
+---------+---------+-----------------+------------------+------------------+
* ^
* |
- * sum(y) aggOffsetInRow = 4
+ * sum(y)
* }}}
*
*/
private[flink] def createPrepareMapFunction(
namedAggregates: Seq[CalcitePair[AggregateCall, String]],
groupings: Array[Int],
inputType: RelDataType)
- : MapFunction[Row, Row] = {
--- End diff --
Ok, based on the DEV discussion, I thought we are going to fix the code
style in the new PRs. But you are right, I should just keep the style changes
in the new lines. I will discard the "style only" change.
> Apply new aggregation functions for datastream and dataset tables
> -----------------------------------------------------------------
>
> Key: FLINK-5768
> URL: https://issues.apache.org/jira/browse/FLINK-5768
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Apply new aggregation functions for datastream and dataset tables
> This includes:
> 1. Change the implementation of the DataStream aggregation runtime code to
> use new aggregation functions and aggregate dataStream API.
> 2. DataStream will be always running in incremental mode, as explained in
> 06/Feb/2017 in FLINK5564.
> 2. Change the implementation of the Dataset aggregation runtime code to use
> new aggregation functions.
> 3. Clean up unused class and method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
