[
https://issues.apache.org/jira/browse/FLINK-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892101#comment-15892101
]
ASF GitHub Bot commented on FLINK-5934:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3440#discussion_r103903694
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -184,31 +202,14 @@
// ------ Fields that are relevant to the execution and need to be
cleared before archiving -------
- /** The slot provider to use for allocating slots for tasks as they are
needed */
- private SlotProvider slotProvider;
-
- /** Strategy to use for restarts */
- private RestartStrategy restartStrategy;
-
- /** The classloader for the user code. Needed for calls into user code
classes */
- private ClassLoader userClassLoader;
-
/** The coordinator for checkpoints, if snapshot checkpoints are
enabled */
private CheckpointCoordinator checkpointCoordinator;
/** Checkpoint stats tracker separate from the coordinator in order to
be
* available after archiving. */
+ @SuppressWarnings("NonSerializableFieldInSerializableClass")
private CheckpointStatsTracker checkpointStatsTracker;
--- End diff --
This annotation is useless since `ExecutionGraph` is no longer
`Serializable`. I think this is an artifact from froward porting the changes to
`1.2`. Will remove it.
> Scheduler in ExecutionGraph null if failure happens in
> ExecutionGraph.restoreLatestCheckpointedState
> ----------------------------------------------------------------------------------------------------
>
> Key: FLINK-5934
> URL: https://issues.apache.org/jira/browse/FLINK-5934
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.2.0, 1.1.4, 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> If {{ExecutionGraph.restoreLatestCheckpointedState}} fails with an exception,
> then all subsequent recoveries will fail because the {{scheduler}} has not
> been set in the {{ExecutionGraph}}.
> I propose to set the {{scheduler}} when the {{ExecutionGraph}} is created to
> avoid this problem.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
