Github user DmytroShkvyra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r103987812
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
 ---
    @@ -1101,6 +1101,45 @@ class ScalarFunctionsTest extends ExpressionTestBase 
{
           "true")
       }
     
    +  @Test
    +  def testInExpressions(): Unit = {
    +    testTableApi(
    --- End diff --
    
    @twalthr Are you sure? That we need use IN with POJOs/Tuples/Case classes?
    First of all I will hit performance because compare of these types too 
complicated. it's easier get subset of id's and use IN than compare POJOs and 
Case classes. More over we cant it use in SQL string statements (we need parse 
POJO and case classes from string)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to