[
https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894054#comment-15894054
]
ASF GitHub Bot commented on FLINK-5758:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3391#discussion_r104122545
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -174,36 +152,28 @@ public static ActorSystem startActorSystem(
public static WebMonitor startWebMonitorIfConfigured(
Configuration config,
ActorSystem actorSystem,
- ActorRef jobManager,
Logger logger) throws Exception {
-
// this ensures correct values are present in the web frontend
final Address address = AkkaUtils.getAddress(actorSystem);
config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
address.host().get());
config.setString(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
address.port().get().toString());
- if (config.getInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY,
0) >= 0) {
- logger.info("Starting JobManager Web Frontend");
+ logger.info("Starting JobManager Web Frontend");
- LeaderRetrievalService leaderRetrievalService =
-
LeaderRetrievalUtils.createLeaderRetrievalService(config, jobManager);
+ LeaderRetrievalService leaderRetrievalService =
+
LeaderRetrievalUtils.createLeaderRetrievalService(config);
- // start the web frontend. we need to load this
dynamically
- // because it is not in the same project/dependencies
- WebMonitor monitor =
WebMonitorUtils.startWebRuntimeMonitor(
- config, leaderRetrievalService, actorSystem);
+ // start the web frontend. we need to load this dynamically
+ // because it is not in the same project/dependencies
+ WebMonitor monitor = WebMonitorUtils.startWebRuntimeMonitor(
+ config, leaderRetrievalService, actorSystem);
- // start the web monitor
- if (monitor != null) {
- String jobManagerAkkaURL =
AkkaUtils.getAkkaURL(actorSystem, jobManager);
- monitor.start(jobManagerAkkaURL);
- }
- return monitor;
- }
- else {
- return null;
+ if (monitor != null) {
+
monitor.start(JobManager.getRemoteJobManagerAkkaURL(config));
--- End diff --
I think it is not a good idea to bake in the constraint in this method that
the `JobManager` always have to be started under the same actor name. This is
brittle and I think it would be better to pass in the JobManager's actor name
to the method.
> Port-range for the web interface via YARN
> -----------------------------------------
>
> Key: FLINK-5758
> URL: https://issues.apache.org/jira/browse/FLINK-5758
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Affects Versions: 1.2.0, 1.1.4, 1.3.0
> Reporter: Kanstantsin Kamkou
> Assignee: Yelei Feng
> Labels: network
>
> In case of YARN, the {{ConfigConstants.JOB_MANAGER_WEB_PORT_KEY}} [is
> changed to
> 0|https://github.com/apache/flink/blob/release-1.2.0/flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java#L526].
> Please allow port ranges in this case. DevOps need that.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
