[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894244#comment-15894244 ]
ASF GitHub Bot commented on FLINK-5824: --------------------------------------- GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3468 [FLINK-5824] Fix String/byte conversions without explicit encoding Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text") - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message (including the JIRA id) - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink flink5824 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3468 ---- commit 0aaf7a843ffb4ef5667e9b2517fd537f3b0323b5 Author: Dawid Wysakowicz <da...@getindata.com> Date: 2017-03-03T12:24:49Z [FLINK-5824] Fix String/byte conversions without explicit encoding ---- > Fix String/byte conversions without explicit encoding > ----------------------------------------------------- > > Key: FLINK-5824 > URL: https://issues.apache.org/jira/browse/FLINK-5824 > Project: Flink > Issue Type: Bug > Components: Python API, Queryable State, State Backends, > Checkpointing, Webfrontend > Reporter: Ufuk Celebi > Assignee: Dawid Wysakowicz > Priority: Blocker > > In a couple of places we convert Strings to bytes and bytes back to Strings > without explicitly specifying an encoding. This can lead to problems when > client and server default encodings differ. > The task of this JIRA is to go over the whole project and look for > conversions where we don't specify an encoding and fix it to specify UTF-8 > explicitly. > For starters, we can {{grep -R 'getBytes()' .}}, which already reveals many > problematic places. -- This message was sent by Atlassian JIRA (v6.3.15#6346)