[ 
https://issues.apache.org/jira/browse/FLINK-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894283#comment-15894283
 ] 

ASF GitHub Bot commented on FLINK-5861:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3395#discussion_r104130678
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/JobManagerConnectionListener.java
 ---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.taskexecutor;
    +
    +import org.apache.flink.runtime.jobmaster.JobMasterGateway;
    +
    +import java.util.UUID;
    +
    +/**
    + * Listener that will be notified when {@link JobManagerConnection} 
changed.
    + */
    +public interface JobManagerConnectionListener {
    +   /**
    +    * Notify job manager connection changed.
    +    *
    +    * @param jobMasterGateway   the job master gateway
    --- End diff --
    
    tab or multiple whitespace indentations after `jobMasterGateway`.


> TaskManager's components support updating JobManagerConnection
> --------------------------------------------------------------
>
>                 Key: FLINK-5861
>                 URL: https://issues.apache.org/jira/browse/FLINK-5861
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, JobManager
>            Reporter: Biao Liu
>            Assignee: Biao Liu
>             Fix For: 1.3.0
>
>
> Some components in TaskManager, such as TaskManagerActions, 
> CheckpointResponder, ResultPartitionConsumableNotifier, 
> PartitionProducerStateChecker, need to support updating JobManagerConnection. 
> So when JobManager fails and recovers, the tasks who keep old 
> JobManagerConnection can be notified to update JobManagerConnection. The 
> tasks can continue doing their jobs without failure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to