Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3395#discussion_r104135016
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/JobManagerConnection.java
---
@@ -98,4 +103,15 @@ public ResultPartitionConsumableNotifier
getResultPartitionConsumableNotifier()
public PartitionProducerStateChecker getPartitionStateChecker() {
return partitionStateChecker;
}
+
+ public void registerListener(JobManagerConnectionListener listener) {
+ jobManagerConnectionListeners.add(listener);
+ }
+
+ public void notifyListener(JobManagerConnection
newJobManagerConnection) {
+ for (JobManagerConnectionListener listener:
jobManagerConnectionListeners) {
+
listener.notifyJobManagerConnectionChanged(newJobManagerConnection.getJobManagerGateway(),
+ newJobManagerConnection.getLeaderId());
+ }
+ }
--- End diff --
Why do you need this listener pattern here? `JobManagerConnection` already
holds a reference to all except for the `InputSplitProvider` instances.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
