Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3304#discussion_r104161807
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
 ---
    @@ -119,6 +122,9 @@ public boolean equals(Object obj) {
                }
                else if (obj != null && obj.getClass() == 
ResourceProfile.class) {
                        ResourceProfile that = (ResourceProfile) obj;
    +                   if (this == ResourceProfile.UNIVERSAL || that == 
ResourceProfile.UNIVERSAL) {
    +                           return true;
    +                   }
    --- End diff --
    
    The contract of the universal slot should not be reflected via the `equals` 
method of an `Object`. This is highly dangerous.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to