[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894999#comment-15894999
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3438
I looked over the changes and didn't find anything critical. The only thing
that made me thinking was the boxed `Long` type for the timestamp(). I assume
you decided for this approach to signal timestamp unavailability using `null`.
The Java documentation does not recommend to rely on autoboxing for performance
critical code:
http://docs.oracle.com/javase/1.5.0/docs/guide/language/autoboxing.html
Tests, Scala API were done. I assume that we don't need to explicitly
mention support for the process function on non-keyed streams.
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Assignee: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
