[ 
https://issues.apache.org/jira/browse/FLINK-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895874#comment-15895874
 ] 

ASF GitHub Bot commented on FLINK-5909:
---------------------------------------

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/3434
  
    Hi @greghogan, thank you for the PR.
    
    I didn't spot anything that needs fixing, but I'm wondering what's the 
motivation to add these interfaces. I see how `toVerboseString()` is useful, 
but not really why `AnalyticResult` is needed. Also, why introduce  
`UnaryResult`, `BinaryResult`, and `TertiaryResult` instead of simply using 
tuple types?
    
    I also see that this PR contains no changes to the docs and that the 
current 1.3-SNAPSHOT docs already reflect the changes of this PR. What am I 
missing here?


> Interface for GraphAlgorithm results
> ------------------------------------
>
>                 Key: FLINK-5909
>                 URL: https://issues.apache.org/jira/browse/FLINK-5909
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.3.0
>
>
> Create {{AlgorithmResult}} and {{AnalyticResult}} interfaces for library 
> algorithms to implement. This flattens algorithm results to a single tuple.
> Also create interfaces for {{UnaryResult}}, {{BinaryResult}}, and 
> {{TertiaryResult}} implementing methods to access the 0th, 1st, and 2nd 
> vertices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to