Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104297285
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/AvgAggFunction.scala
---
@@ -290,6 +317,19 @@ class DecimalAvgAggFunction extends
AggregateFunction[BigDecimal] {
}
}
+ override def retract(accumulator: Accumulator, value: Any): Unit = {
+ if (value != null) {
+ val v = value.asInstanceOf[BigDecimal]
+ val accum = accumulator.asInstanceOf[DecimalAvgAccumulator]
+ if (accum.f1 == 0) {
+ accum.f0 = v
--- End diff --
should be `accum.f0 = v.negate()`.
I think we can even remove the `if (accum.f1 == 0)` condition and always
subtract since `accum.f0` is initialized with `ZERO`. Same would apply for
`accumulate`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
