[
https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895923#comment-15895923
]
ASF GitHub Bot commented on FLINK-5963:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3472#discussion_r104298822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.runtime.aggregate
+
+import java.lang.Iterable
+
+import org.apache.flink.api.common.functions.RichGroupReduceFunction
+import org.apache.flink.configuration.Configuration
+import org.apache.flink.table.functions.{Accumulator, AggregateFunction}
+import org.apache.flink.types.Row
+import org.apache.flink.util.{Collector, Preconditions}
+
+/**
+ * [[RichGroupReduceFunction]] to compute aggregates that do not support
preaggregation for batch
+ * (DataSet) queries.
+ *
+ * @param aggregates The aggregate functions.
+ * @param aggInFields The positions of the aggregation input fields.
+ * @param gkeyOutMapping The mapping of group keys between input and
output positions.
+ * @param aggOutMapping The mapping of aggregates to output positions.
+ * @param groupingSetsMapping The mapping of grouping set keys between
input and output positions.
+ * @param finalRowArity The arity of the final resulting row.
+ */
+class DataSetAggFunction(
+ private val aggregates: Array[AggregateFunction[_ <: Any]],
+ private val aggInFields: Array[Int],
+ private val aggOutMapping: Array[(Int, Int)],
+ private val gkeyOutMapping: Array[(Int, Int)],
+ private val groupingSetsMapping: Array[(Int, Int)],
+ private val finalRowArity: Int)
+ extends RichGroupReduceFunction[Row, Row] {
+
+ private var output: Row = _
+
+ private var intermediateGKeys: Option[Array[Int]] = None
+ private val aggsWithIdx: Array[(AggregateFunction[_], Int)] =
aggregates.zipWithIndex
+ private var accumulators: Array[Accumulator] = _
+
+ override def open(config: Configuration) {
+ Preconditions.checkNotNull(aggregates)
+ Preconditions.checkNotNull(aggInFields)
+ Preconditions.checkNotNull(aggOutMapping)
+ Preconditions.checkNotNull(gkeyOutMapping)
+ accumulators = new Array(aggregates.length)
--- End diff --
good point! thanks
> Remove preparation mapper of DataSetAggregate
> ---------------------------------------------
>
> Key: FLINK-5963
> URL: https://issues.apache.org/jira/browse/FLINK-5963
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Minor
>
> With the new UDAGG interface we do not need the preparation mapper anymore.
> It adds overhead because
> - it is another operator
> - it prevents to use {{AggregateFunction.accumulate()}} in a combiner or
> reducer.
> Hence, it should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
