Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104304057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class AggregateFunction[T] extends
UserDefinedFunction {
def createAccumulator(): Accumulator
/**
+ * Retract the input values from the accumulator instance.
+ *
+ * @param accumulator the accumulator which contains the current
+ * aggregated results
+ * @param input the input value (usually obtained from a new
arrived data)
--- End diff --
Ah, OK. but I think the above comments should be clear enough: "Retract the
input values from the accumulator instance" I think we can leave it as this
because it makes accumulate and retract interface consistent and clean. We will
have (user defined) multiple inputs for both accumulate and retract in the near
future, at which point we will anyway not control the naming of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
