[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896058#comment-15896058
]
ASF GitHub Bot commented on FLINK-5956:
---------------------------------------
Github user shaoxuan-wang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3470#discussion_r104304057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -35,6 +36,18 @@ abstract class AggregateFunction[T] extends
UserDefinedFunction {
def createAccumulator(): Accumulator
/**
+ * Retract the input values from the accumulator instance.
+ *
+ * @param accumulator the accumulator which contains the current
+ * aggregated results
+ * @param input the input value (usually obtained from a new
arrived data)
--- End diff --
Ah, OK. but I think the above comments should be clear enough: "Retract the
input values from the accumulator instance" I think we can leave it as this
because it makes accumulate and retract interface consistent and clean. We will
have (user defined) multiple inputs for both accumulate and retract in the near
future, at which point we will anyway not control the naming of this.
> Add retract method into the aggregateFunction
> ---------------------------------------------
>
> Key: FLINK-5956
> URL: https://issues.apache.org/jira/browse/FLINK-5956
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Retraction method is help for processing updated message. It will also very
> helpful for window Aggregation. This PR will first add retraction methods
> into the aggregateFunctions, such that on-going over window Aggregation can
> get benefit from it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
