[ 
https://issues.apache.org/jira/browse/FLINK-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897135#comment-15897135
 ] 

ASF GitHub Bot commented on FLINK-5645:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3377#discussion_r104394092
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ---
    @@ -1311,6 +1311,19 @@ public boolean updateState(TaskExecutionState state) 
{
                }
        }
     
    +   private Map<String, Accumulator<?, ?>> 
deserializeAccumulators(TaskExecutionState state) {
    --- End diff --
    
    I've checked that returning `null` is the same behaviour as in 
`accumulators.deserializeUserAccumulators(userClassLoader)`. In general it 
would be good to add annotations for `@Nullable` return types or simply return 
empty collections, but that's an orthogonal change.


> IOMetrics transfer through ExecGraph does not work for failed jobs
> ------------------------------------------------------------------
>
>                 Key: FLINK-5645
>                 URL: https://issues.apache.org/jira/browse/FLINK-5645
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>
> While a job is running the web-interface polls IO metrics using the 
> MetricFetcher/MetricQueryService. For finished jobs these metrics are stored 
> in the ExecutionGraph; each vertex has an IOMetrics object; basically a 
> snapshot taken when the task was finished. 
> For completed jobs this mechanism is working. However, for failed jobs it 
> doesn't; in this case last fetched metrics are displayed.
> This isn't intended behavior and should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to