Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3460#discussion_r104408311
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
 ---
    @@ -120,15 +59,9 @@
     
        private final FiniteDuration timeout;
     
    -   /** The path in which the static documents are */
    -   private final File rootPath;
    -
        /** Whether the web service has https enabled */
        private final boolean httpsEnabled;
     
    -   /** The log for all error reporting */
    -   private final Logger logger;
    -
        private String localJobManagerAddress;
     
        public StaticFileServerHandler(
    --- End diff --
    
    Could you remove this constructor and only use the other one? This one is 
only used via the other one and the logger is never overwritten.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to