[ 
https://issues.apache.org/jira/browse/FLINK-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897492#comment-15897492
 ] 

ASF GitHub Bot commented on FLINK-1579:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3460#discussion_r104435301
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/NettySetup.java
 ---
    @@ -0,0 +1,132 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.webmonitor.utils;
    +
    +import io.netty.bootstrap.ServerBootstrap;
    +import io.netty.channel.Channel;
    +import io.netty.channel.ChannelFuture;
    +import io.netty.channel.ChannelInitializer;
    +import io.netty.channel.nio.NioEventLoopGroup;
    +import io.netty.channel.socket.SocketChannel;
    +import io.netty.channel.socket.nio.NioServerSocketChannel;
    +import io.netty.handler.codec.http.HttpServerCodec;
    +import io.netty.handler.codec.http.router.Handler;
    +import io.netty.handler.codec.http.router.Router;
    +import io.netty.handler.ssl.SslHandler;
    +import io.netty.handler.stream.ChunkedWriteHandler;
    +import org.apache.flink.runtime.webmonitor.HttpRequestHandler;
    +import org.apache.flink.runtime.webmonitor.PipelineErrorHandler;
    +import org.slf4j.Logger;
    +
    +import javax.net.ssl.SSLContext;
    +import javax.net.ssl.SSLEngine;
    +import java.io.File;
    +import java.net.InetSocketAddress;
    +
    +public class NettySetup {
    +   private final Router router;
    +   private final Logger LOG;
    +   private final File uploadDir;
    +   private final SSLContext serverSSLContext;
    +   private final ServerBootstrap bootstrap;
    +   private final Channel serverChannel;
    +
    +   public NettySetup(Router router, Logger log, File directory, SSLContext 
sslContext, String configuredAddress, int configuredPort) throws 
InterruptedException {
    +           this.router = router;
    --- End diff --
    
    Add checks for not null?


> Create a Flink History Server
> -----------------------------
>
>                 Key: FLINK-1579
>                 URL: https://issues.apache.org/jira/browse/FLINK-1579
>             Project: Flink
>          Issue Type: New Feature
>          Components: Distributed Coordination
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>
> Right now its not possible to analyze the job results for jobs that ran on 
> YARN, because we'll loose the information once the JobManager has stopped.
> Therefore, I propose to implement a "Flink History Server" which serves  the 
> results from these jobs.
> I haven't started thinking about the implementation, but I suspect it 
> involves some JSON files stored in HDFS :)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to