Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3460#discussion_r104436518
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java
 ---
    @@ -32,6 +32,10 @@
        public static final ConfigOption<Integer> MAX_ATTEMPTS_HISTORY_SIZE =
                        
key("job-manager.max-attempts-history-size").defaultValue(16);
     
    +   public static final ConfigOption<String> ARCHIVE_DIR =
    +                   key("job-manager.archive.dir")
    --- End diff --
    
    I know that you are following this classes example, but we have 
`jobmanager` as the regular config option spelling in the shipped default 
config. We need to change this and create a issue to rename the max attempts 
key accordingly.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to