[
https://issues.apache.org/jira/browse/FLINK-5882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898833#comment-15898833
]
ASF GitHub Bot commented on FLINK-5882:
---------------------------------------
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3407#discussion_r104598155
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/TableFunctionCallGen.scala
---
@@ -45,13 +45,23 @@ class TableFunctionCallGen(
operands: Seq[GeneratedExpression])
: GeneratedExpression = {
// determine function signature
- val matchingSignature = getSignature(tableFunction, signature)
+ val matchingMethod = getEvalMethod(tableFunction, signature)
.getOrElse(throw new CodeGenException("No matching signature
found."))
+ val matchingSignature = matchingMethod.getParameterTypes
+
+ // zip for variable signatures
+ var paramToOperands = matchingSignature.zip(operands)
+ var i = paramToOperands.length
+ while (i < operands.length
--- End diff --
I think this while loop can be replaced with `zipAll`
> TableFunction (UDTF) should support variable types and variable arguments
> -------------------------------------------------------------------------
>
> Key: FLINK-5882
> URL: https://issues.apache.org/jira/browse/FLINK-5882
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhuoluo Yang
> Assignee: Zhuoluo Yang
>
> It's the second approach of FLINK-5826.
> We would like to make table functions (UDTF) of Flink support variable
> arguments.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
