[
https://issues.apache.org/jira/browse/FLINK-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900283#comment-15900283
]
ASF GitHub Bot commented on FLINK-5975:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r104795107
--- Diff:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorkerTest.java
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.mesos.runtime.clusterframework;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.mesos.util.MesosArtifactResolver;
+import org.apache.flink.runtime.clusterframework.ContainerSpecification;
+import
org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters;
+import org.apache.flink.util.TestLogger;
+import org.apache.mesos.Protos;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import scala.Option;
+
+import java.util.List;
+
+import static org.junit.Assert.*;
+
+public class LaunchableMesosWorkerTest extends TestLogger {
+ MesosTaskManagerParameters params =
Mockito.mock(MesosTaskManagerParameters.class);
+ MesosArtifactResolver resolver =
Mockito.mock(MesosArtifactResolver.class);
+ ContainerSpecification containerSpec =
Mockito.mock(ContainerSpecification.class);
+ Protos.TaskID taskId =
Protos.TaskID.newBuilder().setValue("1234").build();
+ LaunchableMesosWorker worker = new LaunchableMesosWorker(resolver,
params, containerSpec, taskId);
+
+ @Test
+ public void volumes() throws Exception {
--- End diff --
by convention these method names should being with "test", i.e
"testVolumes()".
> Mesos should support adding volumes to launched taskManagers
> ------------------------------------------------------------
>
> Key: FLINK-5975
> URL: https://issues.apache.org/jira/browse/FLINK-5975
> Project: Flink
> Issue Type: Improvement
> Components: Mesos
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Addison Higham
> Priority: Minor
>
> Flink needs access to shared storage.
> In many cases, this is HDFS, but it would be nice to also support file URIs
> on an mounted NFS for example.
> Mesos exposes APIs for adding volumes, so it should be relatively simply to
> add this.
> As an example, here is the spark code for supporting volumes:
> https://github.com/apache/spark/blob/master/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala#L35
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
