[
https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900622#comment-15900622
]
ASF GitHub Bot commented on FLINK-5903:
---------------------------------------
Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r104836285
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor
createDescriptor(String defaultApplicationN
if (cmd.hasOption(SLOTS.getOpt())) {
int slots =
Integer.valueOf(cmd.getOptionValue(SLOTS.getOpt()));
yarnClusterDescriptor.setTaskManagerSlots(slots);
+ } else if (config.containsKey(ConfigConstants.YARN_VCORES)) {
--- End diff --
@tillrohrmann You mean YARN_VCORES is deprecated now? After checking code I
found there're two places where we still use it:
[here](https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java#L317)
and
[here](https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java#L339),
especially the latter one is used for container request.
> taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in
> YARN mode
> ---------------------------------------------------------------------------------------
>
> Key: FLINK-5903
> URL: https://issues.apache.org/jira/browse/FLINK-5903
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Tao Wang
> Assignee: Tao Wang
> Attachments: set taskmanager.numberOfTaskSlots to 6.JPG, set
> yarn.container.vcores to 5_JM.JPG, set yarn.container.vcores to 5_RM.JPG
>
>
> Now Flink did not respect taskmanager.numberOfTaskSlots and
> yarn.containers.vcores in flink-conf.yaml, but only -s parameter in CLI.
> Details is that taskmanager.numberOfTaskSlots is not working in anyway
> andyarn.containers.vcores is only used in requesting container(TM) resources
> but not aware to TM, which means TM will always think it has default(1) Slots
> if -s is not configured.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
