[ 
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900981#comment-15900981
 ] 

ASF GitHub Bot commented on FLINK-4326:
---------------------------------------

GitHub user patricklucas opened a pull request:

    https://github.com/apache/flink/pull/3492

    [FLINK-4326] [scripts] Flink foreground services

    This PR consists of @greghogan's commits from #3351 with the merge 
conflicts fixed.
    
    If merged, this PR supplants #3351, which can be closed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/patricklucas/flink 
FLINK-4326_start_in_foreground

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3492
    
----
commit 0867c868508183e2c5b29f8f695fd13dd9f07ea3
Author: Greg Hogan <c...@greghogan.com>
Date:   2016-10-07T20:06:48Z

    [FLINK-4326] [scripts] Flink foreground services
    
    Add a "start-foreground" option to the Flink service scripts which does
    not daemonize the service nor redirect output.

commit 41ab9b7e905d6bf7fbf647808f54888923b3257f
Author: Greg Hogan <c...@greghogan.com>
Date:   2017-02-21T17:37:04Z

    Add logging configuration

----


> Flink start-up scripts should optionally start services on the foreground
> -------------------------------------------------------------------------
>
>                 Key: FLINK-4326
>                 URL: https://issues.apache.org/jira/browse/FLINK-4326
>             Project: Flink
>          Issue Type: Improvement
>          Components: Startup Shell Scripts
>    Affects Versions: 1.0.3
>            Reporter: Elias Levy
>
> This has previously been mentioned in the mailing list, but has not been 
> addressed.  Flink start-up scripts start the job and task managers in the 
> background.  This makes it difficult to integrate Flink with most processes 
> supervisory tools and init systems, including Docker.  One can get around 
> this via hacking the scripts or manually starting the right classes via Java, 
> but it is a brittle solution.
> In addition to starting the daemons in the foreground, the start up scripts 
> should use exec instead of running the commends, so as to avoid forks.  Many 
> supervisory tools assume the PID of the process to be monitored is that of 
> the process it first executes, and fork chains make it difficult for the 
> supervisor to figure out what process to monitor.  Specifically, 
> jobmanager.sh and taskmanager.sh should exec flink-daemon.sh, and 
> flink-daemon.sh should exec java.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to