Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3446#discussion_r105021165
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
 ---
    @@ -226,16 +200,43 @@ public CompletedCheckpoint getLatestCheckpoint() 
throws Exception {
                        return null;
                }
                else {
    -                   return 
checkpointStateHandles.getLast().f0.retrieveState();
    +                   while(!checkpointStateHandles.isEmpty()) {
    +                           
Tuple2<RetrievableStateHandle<CompletedCheckpoint>, String> 
checkpointStateHandle = checkpointStateHandles.peekLast();
    +
    +                           try {
    +                                   return 
retrieveCompletedCheckpoint(checkpointStateHandle);
    +                           } catch (FlinkException e) {
    --- End diff --
    
    I would catch more than `FlinkException` here - after all, we want to fall 
back to earlier checkpoints in any error case, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to