[
https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902248#comment-15902248
]
ASF GitHub Bot commented on FLINK-5635:
---------------------------------------
Github user jgrier commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r105065007
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
+# flink-dist can point to a directory or a tarball on the local system
+ARG flink_dist=NOT_SET
+
# Install build dependencies and flink
+ADD $flink_dist $FLINK_INSTALL_PATH
RUN set -x && \
- mkdir -p $FLINK_INSTALL_PATH && \
- apk --update add --virtual build-dependencies curl && \
- curl -s $(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred\=true)flink/flink-${FLINK_VERSION}/flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz
| \
--- End diff --
Hi guys, thanks for picking up this PR and running with it. I think we
should separate the "official" Docker images issue from this PR. This PR was
about just simply improving the existing Docker tooling and making it easier
for Flink developers to build their own images, maybe with their own tweaks, or
specifying specific Flink releases to build the image from.
On the "official" images topic I'm totally fine with either approach. dA
could do this and maintain those official images or we could do it as part of
Flink and the community can maintain them. The main thing for me is just
seeing that it's super easy for people to get Flink running with Docker and
there is some accepted "official" image for people to grab rather than wading
through a bunch of Flink images generated by various people. That's bad for
the user experience.
Regardless, let's figure out separately how best to get an official image
on DockerHub and get this change finished up because I think the changes here
are useful as is.
> Improve Docker tooling to make it easier to build images and launch Flink via
> Docker tools
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-5635
> URL: https://issues.apache.org/jira/browse/FLINK-5635
> Project: Flink
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 1.2.0
> Reporter: Jamie Grier
> Assignee: Patrick Lucas
>
> This is a bit of a catch-all ticket for general improvements to the Flink on
> Docker experience.
> Things to improve:
> - Make it possible to build a Docker image from your own flink-dist
> directory as well as official releases.
> - Make it possible to override the image name so a user can more easily
> publish these images to their Docker repository
> - Provide scripts that show how to properly run on Docker Swarm or similar
> environments with overlay networking (Kubernetes) without using host
> networking.
> - Log to stdout rather than to files.
> - Work properly with docker-compose for local deployment as well as
> production deployments (Swarm/k8s)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
