Github user wenlong88 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3467#discussion_r105081191
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -265,11 +281,15 @@ public String toString() {
//
------------------------------------------------------------------------
private void returnMemorySegment(MemorySegment segment) {
+ assert Thread.holdsLock(availableMemorySegments);
--- End diff --
Hi, I have a question about assert, because I found that assertion is
disabled in java by default. why not use explicit
`synchronized(availableMemorySegments)` which may be more common usage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
