Github user huawei-flink commented on the issue:

    https://github.com/apache/flink/pull/3459
  
    Hi @fhueske 
    
    I will start with the minor comments: in principle those were done by 
mistake within the rebase...
    Regarding the FunctionCatalog - that was because initially we used our own 
implementation fro ProcTime()....the file as it is now it should not be 
modified. - now after the rebase the proctime is used
    
    Related to the main comments:
    1) scala/java - I think it is a bit restrictive and unfair to say that only 
scala is acceptable here for maintenance reasons  given that a large part of 
the Flink project is written in java... Will you actually impose these 
restriction?
    2) related to the squash commits...we can check out again a new branch and 
add only the modifications in one push - I guess this should be ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to