[ 
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904878#comment-15904878
 ] 

ASF GitHub Bot commented on FLINK-4460:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r105372676
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
 ---
    @@ -419,6 +435,14 @@ public void merge(W mergeResult,
                                registerCleanupTimer(window);
                        }
                }
    +
    +           // side output input event if
    +           // element not handled by any window
    +           // late arriving tag has been set
    +           // windowAssigner is event time and current timestamp + allowed 
lateness no less than element timestamp
    +           if(isSkippedElement && lateDataOutputTag != null && 
isLate(element)) {
    --- End diff --
    
    I just added a test for the behaviour with a "weird" `WindowAssigner`. 


> Side Outputs in Flink
> ---------------------
>
>                 Key: FLINK-4460
>                 URL: https://issues.apache.org/jira/browse/FLINK-4460
>             Project: Flink
>          Issue Type: New Feature
>          Components: Core, DataStream API
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Chen Qin
>            Assignee: Chen Qin
>              Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to