[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905142#comment-15905142
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105401503
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -387,14 +403,25 @@ public int getChainLength() {
protected final StreamStatusProvider streamStatusProvider;
- public ChainingOutput(OneInputStreamOperator<T, ?> operator,
StreamStatusProvider streamStatusProvider) {
+ protected final OutputTag<T> outputTag;
+
+ public ChainingOutput(
+ OneInputStreamOperator<T, ?> operator,
+ StreamStatusProvider streamStatusProvider,
+ OutputTag<T> outputTag) {
this.operator = operator;
this.numRecordsIn = ((OperatorMetricGroup)
operator.getMetricGroup()).getIOMetricGroup().getNumRecordsInCounter();
this.streamStatusProvider = streamStatusProvider;
+ this.outputTag = outputTag;
}
@Override
--- End diff --
Again the two `collect()` methods have much identical code. We can put that
common code in a separate private method and calls this instead of repeating
the code.
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Assignee: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
