[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905378#comment-15905378
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105435806
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
---
@@ -72,6 +76,11 @@ public RecordWriterOutput(
--- End diff --
I can remove the reduplication on `RecordWriterOutput`, `ChainingOutput`
and `CopyingChainingOutput`. Basically those `Outputs` that don't forward to
other outputs but instead push into the operator or into the network. For the
other `Outputs` removing the duplication is not possible because inside the
respective `output()` method they call `output()` of another `Output`. They
call either with an `OutputTag` or without, so the method body is not actually
a duplicate.
I did find another bug, though, where `CopyingBroadcastingOutputCollector`
in `OperatorChain` was not calling the correct `collect()` method on the
downstream `Outputs`. 😃
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Assignee: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
