Github user godfreyhe commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r105811515
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class DataSetCalc(
traitSet: RelTraitSet,
input: RelNode,
rowRelDataType: RelDataType,
- private[flink] val calcProgram: RexProgram, // for tests
+ calcProgram: RexProgram,
ruleDescription: String)
- extends SingleRel(cluster, traitSet, input)
+ extends Calc(cluster, traitSet, input, calcProgram)
with CommonCalc
with DataSetRel {
- override def deriveRowType() = rowRelDataType
+ override def deriveRowType(): RelDataType = rowRelDataType
- override def copy(traitSet: RelTraitSet, inputs:
java.util.List[RelNode]): RelNode = {
- new DataSetCalc(
- cluster,
- traitSet,
- inputs.get(0),
- getRowType,
- calcProgram,
- ruleDescription)
+ override def copy(traitSet: RelTraitSet, child: RelNode, program:
RexProgram): Calc = {
+ new DataSetCalc(cluster, traitSet, child, getRowType, program,
ruleDescription)
}
override def toString: String = calcToString(calcProgram,
getExpressionString)
override def explainTerms(pw: RelWriter): RelWriter = {
- super.explainTerms(pw)
- .item("select", selectionToString(calcProgram, getExpressionString))
- .itemIf("where",
- conditionToString(calcProgram, getExpressionString),
- calcProgram.getCondition != null)
+ pw.input("input", getInput)
+ .item("select", selectionToString(calcProgram,
getExpressionString))
--- End diff --
two spaces for indention
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
