Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3481#discussion_r105825035
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -259,9 +262,11 @@ public String toString() {
throw new IllegalStateException("unsupported
container type");
}
if(containerInfo != null) {
+ containerInfo.addAllVolumes(params.containerVolumes());
--- End diff --
There's an unnecessary restriction here, that volumes may be used only if a
container image is also used. I bet you can use volumes with the Mesos
containerizer without using an image. The code in the `case MESOS:` block
should be reorganized to always set `containerInfo =
Protos.ContainerInfo.newBuilder()`. This way, `containerInfo` will never be
null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
