Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r105891279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -389,11 +389,20 @@ public Task(
++counter;
}
+ invokableHasBeenCanceled = new AtomicBoolean(false);
+
+ // finally, create the executing thread, but do not start it
+ executingThread = new Thread(TASK_THREADS_GROUP, this,
taskNameWithSubtask);
+
+ // add metrics for buffers
+ this.metrics.getIOMetricGroup().initializeBufferMetrics(this);
+
// register detailed network metrics, if configured
if
(tmConfig.getBoolean(TaskManagerOptions.NETWORK_DETAILED_METRICS_KEY)) {
- MetricGroup networkGroup =
metricGroup.addGroup("Network"); // same as in
MetricUtils.instantiateNetworkMetrics()
- MetricGroup outputGroup =
networkGroup.addGroup("Output"); // this is optional
- MetricGroup inputGroup =
networkGroup.addGroup("Input"); // this is optional
+ // similar to MetricUtils.instantiateNetworkMetrics()
but inside this IOMetricGroup
+ MetricGroup networkGroup =
this.metrics.getIOMetricGroup().addGroup("Network");
--- End diff --
this seems a bit strange to me in general and I see several occurrences of
`this.metrics.getIOMetricGroup()` in the code base - which use is preferred?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
