Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3460#discussion_r105906412
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/ArchivedJson.java
 ---
    @@ -27,6 +27,11 @@
      * resembling the REST API.
      */
     public class ArchivedJson {
    +
    +   public static final String ARCHIVE = "archive";
    --- End diff --
    
    Instead of having these constants here that are accessed in different 
placed, we should encapsulate writing out and reading in stuff in a single 
class. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to