[ 
https://issues.apache.org/jira/browse/FLINK-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926053#comment-15926053
 ] 

ASF GitHub Bot commented on FLINK-6059:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/3546

    [FLINK-6059] [table] Reject GenericType<Row> when converting DataSet or 
DataStream to Table

    When converting a `DataSet<Row>` or `DataStream<Row>` into a `Table` which 
has `GenericTypeInfo<Row>` type, the row is treated as atomic type. This is 
always a non-expected and confusing behavior.
    
    With this change converting a `DataSet<Row>` or `DataStream<Row>` with 
`GenericTypeInfo<Row>` into a `Table` fails. Instead we ask for a 
`DataSet<Row>` or `DataStream<Row>` with proper `RowTypeInfo`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableNoGenericRow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3546
    
----
commit 0064a9ed1270d1e139ff9a6b22df5cc95450ce59
Author: Fabian Hueske <[email protected]>
Date:   2017-03-15T12:24:42Z

    [FLINK-6059] [table] Reject GenericType<Row> when converting DataSet or 
DataStream to Table.

----


> Reject DataSet<Row> and DataStream<Row> without RowTypeInformation
> ------------------------------------------------------------------
>
>                 Key: FLINK-6059
>                 URL: https://issues.apache.org/jira/browse/FLINK-6059
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>
> It is not possible to automatically extract proper type information for 
> {{Row}} because it is not typed with generics and holds values in an 
> {{Object[]}}.
> Consequently is handled as {{GenericType<Row>}} unless a {{RowTypeInfo}} is 
> explicitly specified.
> This can lead to unexpected behavior when converting a {{DataSet<Row>}} or 
> {{DataStream<Row>}} into a Table. If the data set or data stream has a 
> {{GenericType<Row>}}, the rows are treated as atomic type and converted into 
> a single field.
> I think we should reject input types of {{GenericType<Row>}} when converting 
> data sets and data streams and request a proper {{RowTypeInfo}}. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to