[
https://issues.apache.org/jira/browse/FLINK-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926474#comment-15926474
]
ASF GitHub Bot commented on FLINK-5962:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3548#discussion_r106208791
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -819,20 +839,25 @@ private void triggerQueuedRequests() {
// trigger the checkpoint from the trigger timer, to
finish the work of this thread before
// starting with the next checkpoint
- ScheduledTrigger trigger = new ScheduledTrigger();
if (periodicScheduling) {
if (currentPeriodicTrigger != null) {
- currentPeriodicTrigger.cancel();
+ currentPeriodicTrigger.cancel(false);
}
- currentPeriodicTrigger = trigger;
- timer.scheduleAtFixedRate(trigger, 0L,
baseInterval);
+ currentPeriodicTrigger =
timer.scheduleAtFixedRate(
+ new ScheduledTrigger(),
+ 0L, baseInterval,
TimeUnit.MILLISECONDS);
}
else {
- timer.schedule(trigger, 0L);
+ timer.execute(new ScheduledTrigger());
--- End diff --
Maybe we can create a singleton `ScheduledTrigger`, then we would save some
object creation.
> Cancel checkpoint canceller tasks in CheckpointCoordinator
> ----------------------------------------------------------
>
> Key: FLINK-5962
> URL: https://issues.apache.org/jira/browse/FLINK-5962
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Till Rohrmann
> Assignee: Stephan Ewen
> Priority: Critical
>
> The {{CheckpointCoordinator}} register a canceller task for each running
> checkpoint. The canceller task's responsibility is to cancel a checkpoint if
> it takes too long to complete. We should cancel this task as soon as the
> checkpoint has been completed, because otherwise we will keep many canceller
> tasks around. This can eventually lead to an OOM exception.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
