Github user huawei-flink commented on a diff in the pull request:
https://github.com/apache/flink/pull/3547#discussion_r106221708
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/rel/LogicalWindowAggregate.scala
---
@@ -37,8 +35,8 @@ class LogicalWindowAggregate(
child: RelNode,
indicator: Boolean,
groupSet: ImmutableBitSet,
- groupSets: util.List[ImmutableBitSet],
- aggCalls: util.List[AggregateCall])
+ groupSets: java.util.List[ImmutableBitSet],
--- End diff --
for some reason it does not build in eclipse in the original way, and
honestly I struggle to understand "the half package name" usage in Scala. Is
there any practical reason for that? and does it break some convention to use
the complete package name? I am asking with honest curiosity, and no polemical
intention. Thanks for clarifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
